@mattstuddert
Posted
Hey Shahin, awesome work on this challenge! Your solution looks great 👍
On the responsive side, everything looks good on mobile and desktop. I'd recommend using a percentage value on a max-width property so that the form can scale up with the screen size before going to the two-column layout. It looks a little narrow on larger tablet sizes.
Your JS looks good. You've got some repetition in your code, like when you're checking if fields are empty. So you could abstract those checks into a validateEmpty function or something. But you've structured your code well.
I'd recommend you look at the solution report and try resolving the accessibility errors though! 🙂
@SJ-Nosrat
Posted
Hi Matt! Thanks for your kind feedback. I'll be sure to apply the suggestions ASAP; I just got started on the "Base apparel website".
I see your point about max-width. Also I'll refactor the JS too.
Thanks again!
@mattstuddert
Posted
@shahin1987 you’re welcome! I hope you enjoy the new challenge!
