
Solution retrospective
Feedbacks are welcome! : )
Please log in to post a comment
Log in with GitHubCommunity feedback
- @benjoquilario
Hi RTX3070, great job on finishing this one, it looks good and response rather well.
some suggestion to improve your code.
- Heading(h1-h6) levels should only increase by one, because you use
h5 heading
, it gives you a warning, useh3
instead you cannot useh5 without h3 and h4
. - Your h1 tag should be at the top of the page content (above any other heading tags in the page code).
- I think you put media queries early, use the
min-width: 1025px or 768px
instead.
Overall you did well, hope it helps
cheers, benjo
Marked as helpful - Heading(h1-h6) levels should only increase by one, because you use
- @MikeBish13
The screenshot you've taken looks pretty accurate compared to the final design, so great job on that!
However, you should consider 'responsive layouts' and how the page looks on different screen sizes. From what I can tell, the full page 'grid' layout only shows at a screen size of 1400, and then reverts back to the mobile layout at screen sizes below that. Have a think about a suitable 'break point' to implement into your project and rememeber -- not everyone views a page on a full-screen!
Hope that helps and keep up the good work!
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord