Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 9 months ago

HTML5, CSS3,, DEVDOCS

MindCode-89•130
@MindCode-89
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • RasMurph420•50
    @RasMurph420
    Posted 9 months ago

    HTML Review Strengths Semantic Structure: You’ve used semantic HTML elements like <main>, <section>, and <div>, which helps improve the readability and accessibility of your code. Viewport and Favicon: Including a viewport meta tag and a favicon is good practice for mobile responsiveness and branding. Font Loading: You’ve efficiently preconnected to Google Fonts, which can improve loading times for the font. Areas for Improvement Image Alt Text: The alt attribute for the image should be more descriptive. Instead of alt="images-QR_CODE", consider using something like alt="QR code linking to Frontend Mentor". This helps with accessibility. Consistent Naming Conventions: Your class names vary in style (e.g., content_images_qr_code vs. content_title). Choose a consistent naming convention (e.g., camelCase or kebab-case) for better readability. Accessibility: Consider wrapping your main content in a <header> and <footer> for better semantic structure. Additionally, ensure that the text contrast meets accessibility standards. CSS Review Strengths Global Reset: Using * { margin: 0; padding: 0; } is a good approach to remove default browser styles and maintain consistency. Responsive Design: Using width in ems for your main container is a good way to support responsive design. Areas for Improvement Use of Units: Instead of fixed pixel values (e.g., width: 350px; height: 350px;), consider using percentages or viewport units (vw/vh) for better responsiveness. This will help the layout adapt better on smaller screens. Unnecessary CSS Classes: The class content_images_qr_code does not have any styles applied. You can remove it unless you plan to add styles later. Attribute Alignment: The float: center; property in the .attribution class is incorrect. Instead, you can use display: flex; justify-content: center; to center the attribution text. Text Decoration: The text-decoration: none; property in the .attribution class doesn't have any effect because it is not applied to any links. You might want to apply it specifically to the anchor (<a>) elements if you want to remove underlines.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub