Raymart Pamplona• 16,140
@pikapikamart
Posted
Hey, great work on this one. Layout in desktop seems fine, but there is this black-space on both sides of the body
tag. Layout in desktop have this as well, but the layout itself is fine.
Some suggestions would be:
- Remove
background-color
in thehtml
element. This what creates that black colored sides which is not really great to look at. - Avoid using multiple usage of
h1
element. Always have at least only 1h1
element. Those could have been replaced withh2
. On this one, theh1
would be a screen reader only text. Thish1
would havesr-only
as a class, this class is just a css stylings that is intended for screen reader users, you can search up the web for this styling and apply it in theh1
element, along with the appropriate text inside it. - When using
alt
attribute, avoid adding words that relates to "graphic" like "logo, image, icon, picture..." as a value foralt
attribute. Assistive tech will handle those for you. - The
learn more
should have been usinga
tag. Since this is not aform
button
are not used since there are no control it should do. - The
learn more
should have a visual-indicator, right now, if you tab on them you won't see anything that will inform you that you are focusing on the. On their:focus-visible
add anoutline
orbox-shadow
orborder
. Just an indicator.
Aside from those, great work.
Marked as helpful
1