@sirriah
Posted
Hello,
Nice work. I have some suggestions:
- Not everything should be in div tag. For example for paragraphs use p tag, etc. Look at some articles or videos - list of all tags and FreeCodeCamp - semantic HTML
- Try to use BEM naming or another naming standard. This project is small, but If you will work on something bigger, you will get lost. [Video about BEM] (https://www.youtube.com/watch?v=SLjHSVwXYq4)
- As josuke0227 mentions above - the responsiveness is not good. Try to add another breakpoint. I know that in the starter files are only designs for mobile and desktop, but It would be better, if the page will be visible in all devices. [Responsive design] (https://developer.mozilla.org/en-US/docs/Learn/CSS/CSS_layout/Responsive_Design) Your browser will help you with the media queries [Responsive design mode in Firefox] (https://developer.mozilla.org/en-US/docs/Tools/Responsive_Design_Mode)
Have a nice day :)
@aasthaanand123
Posted
@sirriah Thanks for the feedback. I do think I'll start incorporating BEM in my code and I'll look into the responsiveness also since I did struggled in media queries the code became really messy.