Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 4 months ago

HTML5, SASS, Flexbox, Mobile-first, Vanilla JS, A11y

accessibility, jest, sass/scss, react-testing-library
P
Imre Bartis•60
@imrebartis
A solution to the FAQ accordion challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

What I'm proud of

I'm particularly proud of the accessibility implementation in this project. The careful attention to ARIA attributes, keyboard navigation, and reduced motion preferences demonstrates a commitment to inclusive design. The clean separation of concerns between HTML structure, SCSS styling, and JavaScript behavior made the code maintainable and well-organized.

What I'd do differently

For future iterations, I would:

  • Implement a robust state management system for complex accordion interactions
  • Create reusable utility classes to reduce CSS duplication
  • Add proper error boundaries for better error handling
What challenges did you encounter, and how did you overcome them?
  • Fixing transition issues: Resolved CSS transition problems to ensure smooth animations (commit).
  • Handling deprecated features: Replaced code containing deprecated features to maintain compatibility (commit).
  • Improving testing: Enhanced testing procedures to catch more bugs and ensure reliability (commit).
  • Refactoring code: Refactored code for better readability and maintainability (commit).
What specific areas of your project would you like help with?

All constructive feedback is welcome, but since this is an accessibility focused project, a11y related comments are what I'm most interested in.

Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

No feedback yet. Be the first to give feedback on Imre Bartis's solution.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.