@MelvinAguilar
Posted
Hello there ๐. Good job on completing the challenge !
I have other suggestions about your code that might interest you.
HTML ๐:
- Since this component involves scanning the QR code, the image is not a decoration, so it must have an
alt
attribute. Thealt
attribute should explain its purpose. e.g.QR code to frontendmentor.io
CSS ๐จ:
- Setting a defined
height
for the card component is not recommended (height: 37em;
). The content should define the component height, otherwise, it will not be allowed to extend beyond your specifications.
- To center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here ๐.
I hope you find it useful! ๐
Happy coding!
Marked as helpful
@amelia2802
Posted
@MelvinAguilar Thank you for your valuable feedback! I've modified the code and will remember those strategies for future challenges. ๐