html5,css custom properties and flexbox

Community feedback

• 

  Travolgi 🍕•31,280

  @denielden

  Posted almost 3 years ago

  Hello Saurav, You have done a good work! 😁

  Some little tips to improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of texts... use p for the text not a div
  • You can add the effect :hover creating a div that appears on hover. I used tailwind but you can still see and understand which css properties you can use to do the same. Look here -> my solution
  • use min-height: 100vh to body instead of height, otherwise the content is cut off when the browser height is less than the content
  • instead of using px use relative units of measurement like rem -> read here

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  00
• 

  Raja Junaid Farooq•390

  @Raja-Junaid

  Posted almost 3 years ago

  Hi Saurav! Congratulation on completing this beautiful challenge. Great Job! Welcome to our front-end mentor community. You put so much hard work into your solution. I really like this solution.

  There is 0 HTML ISSUE. And your code is also neat and clean.

  I have some other tips for you to improve your coding skills:

  1- Make your work as decent as possible.

  2- Use comments in your code so this help what's going on.

  3- Make your websites neat and clean.

  4- Use div. main-container for Accessibility in your code.

  5- Also use em and rem in your code.

  I hope this helps you!

  Keep Practicing.

  Happy Coding!

  00