Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML,css

@salahudheen007

Desktop design screenshot for the Stats preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


any suggestions to improve the code?

Community feedback

Davide 1,725

@Da-vi-de

Posted

Hi, i don't really like your choice of implementing CSS in style element, you should have a saperated CSS file, that's the professional way of working.

  • You didn't really follow the task, the background must cover the entire page, in practice means you need to selet the body element and set the background there.

  • id should be used for JS, ids are unique so you can't reuse it again, it's a problem for bigger projects because you end up writing everything twice or more... Never underestimate reusability.

  • I strongly advice you to learn mobile first approach and HTML semantic, a right way to start would be checking your report and try to resolve the issues.

Keep coding :-)

Marked as helpful

0

@salahudheen007

Posted

@Da-vi-de thank you for the suggestions

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord