Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML/CSS Card Component Challenge

Estèlle 40

@meijerestelle

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi! I used this challenge to return back to learning coding after a period of not doing it.

Some things I had trouble with, but would like some feedback on:

  • The rounded corners thing. Couldn't get it to work on the container, so I put them on the individual cards and played with negative margins. Must be a better way to do this I think? Any suggestions?
  • The rounded corners - but vertical. Due to the margins applied on the desktop view, the two bottom cards where slightly shifted to the left. Tried to overrule this with @media, but didn't really work. So I put negative margins on all cards and compensated it with 10px padding in the @media.

Thanks in advance for feedback!

Community feedback

P
ApplePieGiraffe 30,545

@ApplePieGiraffe

Posted

Greetings, Estèlle! 👋

Congratulations on completing your first Frontend Mentor challenge! 🎉 Good work on this one! 👍

In addition to RayaneBengaoui's helpful feedback, I'd like to suggest,

  • Using anchor tags (rather than <button> elements) for the "Learn More" links on the page since they will probably lead the user somewhere.
  • Taking a look at your solution report and trying to clear up some of the errors that are there (it looks like you might have to remove a duplicate ID or two and add the alt attribute to the images in this challenge).
  • Switching to a mobile-friendly layout sooner to prevent a horizontal scroll bar from appearing along the bottom of the page and to make your solution more responsive.

Hope those tips help. 🙂

Keep coding (and happy coding, too)! 😁

1

Estèlle 40

@meijerestelle

Posted

@ApplePieGiraffe Thanks for the feedback! Looks a lot better now :)

0
Rayane 1,935

@RayaneBengaoui

Posted

Hello Estèlle,

Congrats for completing your first challenge ! 🙂

For rounding the corners I think you could proceed this way :

  • Remove these margins and border-radiuses from the cards.

  • On your body, add min-height: 100vh, display: flex, flex-direction: column, justify-content: center and align-items: center. It will center your container in the middle and make sure your body covers the entire viewport.

  • On your container , remove min-height: 100vh because you want your body to cover the viewport, not the container. Also you can remove both width: 960px and min-width: 100vw because you declared a fixed width on your flex items (230px) so the container will be too wide and thus, we won't see the corners.

  • Last, add border-radius: 15px to your container and also overflow: hidden in order to see the border radius.

Let me know if it helped and if you have any questions.

Overall, well done for the challenge and happy coding ! 😃

1

Estèlle 40

@meijerestelle

Posted

@RayaneBengaoui Thanks for the detailed feedback! Looks great now in combination with the feedback of @ApplePieGiraffe :)

0

@codeswithroh

Posted

Instead of using border-radius just use border-top-left-radius or border-top-right-radius. The same follows for the bottom radius as well. This will help you to get the rounded corners in the specific regions as required. For more clarity you can check out my solution as well (https://github.com/codeswithroh/Simple-Card-Layout)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord