Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

HTML_CSS

Tamana•210
@Tamana123-2
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


In this project, I had problem with the image's border radius although I made it the same as expected, but the border-bottom-left and border-bottom-right were getting extra range. Any recommendation regarding to the project would be appreciated, plus I have started Java script but I do not know how to go on except from (w3schools) can you recommend me any other fun and useful source? Thanks!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Eileen dangelo•1,600
    @Eileenpk
    Posted over 2 years ago

    Hi Tamana! your project looks great, and this might be a helpful tip.

    One change to think about is formatting your code with proper code indentation and line breaks. For this project, it doesn't matter as much but it definitely will once you start on bigger projects. It really makes it much easier to read/review/debug/reference the code. I would add the Prettier extension to Vs code if that is the IDE that you are using.

    Here is what the formatted HTML should look like.

    <!DOCTYPE html>
    <html lang="en">
      <head>
        <meta charset="UTF-8" />
        <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <link
          rel="icon"
          type="image/png"
          sizes="32x32"
          href="./images/favicon-32x32.png"
        />
    
        <title>Frontend Mentor | QR code component</title>
        <link rel="stylesheet" href="style.QR.css" />
      </head>
      <body>
        <main>
          <article class="container">
            <img src="./images/image-qr-code.png" alt="" class="img-1" />
            <div class="content">
              <p class="first">
                Improve your front-end skills by building projects
              </p>
    
              <p class="second">
                Scan the QR code to visit Frontend Mentor and take your coding
                skills to the next level
              </p>
            </div>
          </article>
        </main>
      </body>
    </html>
    

    Also, look into Scrimba if you want to learn JavaScript, it's free and a great way to actually get practice and you have help if you need it.

    Here is a link to their free courses

    • https://scrimba.com/allcourses?price=free

    Hope you found this helpful!

    • Let's connect on LinkedIn! - @Eileenpk
  • Finney•3,010
    @Finney06
    Posted over 2 years ago

    Hello there 👋. Good job on completing the challenge !

    Here are some suggestions regarding your code that may be of interest to you.

    HTML 🔤:

    To clear the Accessibility report:

    Use an h1 tag for the main text in the design given and always avoid skipping heading levels; Starting with <h1> and working your way down the heading levels (<h2>, <h3>, etc.) helps ensure that your document has a clear and consistent hierarchy.

    I hope you find it helpful!😏 Above all, the solution you submitted is 👌. 🎉Happy coding!

  • Luca Liebenberg•180
    @lucaliebenberg
    Posted over 2 years ago

    Congrats on completing the challenge!

    Wes Bos has some good practice exercises on JavaScript, and so does JSChallenger:

    https://www.jschallenger.com https://javascript30.com/?ref=steemhunt

    I hope I could help you. Happy Coding!

  • namborghinii•220
    @namborghinii
    Posted over 2 years ago

    Good job on completing the challenge!

    Instead of border-radius: 1.5rem 1.5rem 1.5rem 1.5rem; you can just write border-radrius: 1.5rem;and it will be valid for all corner.

    If you want to practice your JS Skills (or other languages) you should definetely check out codewars.com :))

    I hope I could help you. Happy Coding!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub