@denielden
Posted
Hi Jill, great work on this challenge! π
Here are a few tips for improve your code:
- add
main
tag and wrap the card for improve the Accessibility - using
<hr>
for the line is not the best way because this tag have a semantic meaning... in this case use div withborder-bottom
because this line is decorative - remove
margin-top
fromcard
class because with flex they are superfluous - add
min-height: 100vh
tocontainer
class because Flexbox aligns child items to the size of the parent container - add
transition
also on the text with hover effect
Overall you did well π Hope this help!
Marked as helpful
@jillpandya2594
Posted
@denielden Thank you for your valuable feedback.I will improve on my code according to the tips you mentioned.
@jillpandya2594
Posted
@denielden How do I get rid of bottom margin in the card which can be noticed here
@denielden
Posted
@jillpandya2594 remove min-height
from card
class. Which bottom margin do you mean? I do not understand :)
@jillpandya2594
Posted
@denielden I meant the extra space present in the bottom of the card which shouldn't be there as its not in design.I was viewing the design comparison.
@denielden
Posted
@jillpandya2594 remove it as suggested in my previous comment
@jillpandya2594
Posted
@denielden I removed it with no effect