Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML,CSS image overlay and position property

#accessibility
jill pandyaβ€’ 90

@jillpandya2594

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


All suggestions are welcome

Community feedback

Travolgi πŸ•β€’ 31,480

@denielden

Posted

Hi Jill, great work on this challenge! πŸ˜‰

Here are a few tips for improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • using <hr> for the line is not the best way because this tag have a semantic meaning... in this case use div with border-bottom because this line is decorative
  • remove margin-top from card class because with flex they are superfluous
  • add min-height: 100vh to container class because Flexbox aligns child items to the size of the parent container
  • add transition also on the text with hover effect

Overall you did well 😁 Hope this help!

Marked as helpful

1

jill pandyaβ€’ 90

@jillpandya2594

Posted

@denielden Thank you for your valuable feedback.I will improve on my code according to the tips you mentioned.

1
jill pandyaβ€’ 90

@jillpandya2594

Posted

@denielden How do I get rid of bottom margin in the card which can be noticed here

1
Travolgi πŸ•β€’ 31,480

@denielden

Posted

@jillpandya2594 remove min-height from card class. Which bottom margin do you mean? I do not understand :)

0
jill pandyaβ€’ 90

@jillpandya2594

Posted

@denielden I meant the extra space present in the bottom of the card which shouldn't be there as its not in design.I was viewing the design comparison.

1
Travolgi πŸ•β€’ 31,480

@denielden

Posted

@jillpandya2594 remove it as suggested in my previous comment

1
jill pandyaβ€’ 90

@jillpandya2594

Posted

@denielden I removed it with no effect

1
NitheeshKumar Cβ€’ 440

@NitheeshKumar-C

Posted

Hi thereπŸ˜ƒ,

The solution looks good. Here are some improvement code,

For more accurate center use flex-box:

Based on the problem use :

body {
    min-height: 100vh;
    display: flex;
    justify-content: center;
    flex-direction: column;
}

For <hr> (Horizontal line):

hr {
    border: 1px solid;
}

Happy CodingπŸ‘¨β€πŸ’»,

NitheeshKumar

Marked as helpful

0

jill pandyaβ€’ 90

@jillpandya2594

Posted

@NitheeshKumar-C Thank you for your feedback.I will definitely take your advice.

1
patil sahilβ€’ 440

@Patilsahil821

Posted

hey, awesome you did it very perfect the only thing you have to look that is accessibility issues and html issues except these you did very well and Don't forget to check mine projects also. best of luck for your next projects.....

Marked as helpful

0

jill pandyaβ€’ 90

@jillpandya2594

Posted

@Patilsahil821 Thank you .I will definitely check out your projects.I will try and improve on the issues you mentioned.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord