Looking to hire developers?
I am a newbie in the area, please give me any feedback. I would appreciate it, thank y'all !!!
@Illyaas4Show
Posted
This is a good first attempt, well done!
border-radius: ;box-shadow: ; as it is present on the challenge card and it makes the card pop.main {
display: flex;
justify-content: center;
align-items: centre;
min-height: 100vh;
}
Hopes this helps! Happy coding :)
Marked as helpful
Account Deleted
Hey, Nice work.
Check your css code increase the attribution font-size to 18px.
.attribution { font-size: 11px; // here should be 18px to make it more legible. text-align: center; }
Only your attribution has a comment. Always comment your work section both the html and the css so code reviewer can easily go through. You will appreciate this when you embark on bigger project.
If you found any of these helpful, give it a like.
Happy Coding!
Marked as helpful
@darryncodes
Posted
Hi Erkin,
I really like your solution, it looks great!
Your accessibility report is highlighting a few tweaks you could make:
.container <div> with a <main>.attribution <div> with a <footer><h2> with a <h1>Using semantic html is a really fundamental part of building an accessible page. Also Heading hierarchy is important!
min-height: 100vh; to your <body> to help nice centre the design in the viewportI hope that helps!
Marked as helpful
@ErkinN
Posted
@darryncodes Thank you a lot !!!
@Ifescohub
Posted
@ErikN Your work is well done. It is very close to the project.
Regarding your report, You are getting some of the reports because you wrapped everything in a div tag. To set that, wrap your "container" and "attribution" class in a main and footer tags respectively.
I.e
<main class="container">
//other div
</main>
<footer class="attribution">
//Your text
</footer> ```
Happy coding.
Marked as helpful
@ErkinN
Posted
@Ifescohub Thank you :)
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
