Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML/CSS/SCSS BEM

@rafaelbucher

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi, Any feedbacks on my challenge ? Feel free to tell me. Thx lot

Community feedback

Dharmik_487 1,740

@Dharmik48

Posted

Hey👋,

I found a few issues with the site:

  • Try to use relative units like em and rem more rather than of px.

Apart from these your solution is really nice, keep it up👍

0
Ali Sbane 470

@0x41-li

Posted

Good work. Here are some points:

  • I assume that you did begin the project by working on the desktop and then mobile, I would suggest using a mobile-first design (begin with the mobile design first) in the next project, it's easier.
  • Also I check the project on my computer and phone, but it's too large, meaning that the card goes off the screen horizontally. On the desktop too, I assume that you have large screens, but you need to fix that, even with the scrollbars I can't scroll to the top of the card, I suggest that you add margin-top and margin-bottom at least to make the page scrollbar, in the screen that can't fit the card size.
  • For the alt attribute in the images that are just for the design and don't have any semantic meaning or are related to the content. Leave the alt attribute empty. Also note that when specifying alt attribute's value don't use keywords like image, graphic, Picture, as it's already an image, no need.

Besides those points, keep up the good work.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord