Thomas Hertog• 715
@thomashertog
Posted
your solution looks good visually! some small code improvements can be made though
HTML/accessibility
- you've used a
<section>
, however that doesn't add any semantics nor a landmark.<section>
is only useful if you can associate it with a header <article>
is something that should make sense on it's own page, so definitely not the right element for that plan<a>
is for linking to another page, i'm a bit unsure what other page you would navigate to when changing a plan/proceeding, they might be better off as a<button>
- you're missing an
<h1>
, which is like reading a book without a titleµ - the image on top is meaningful content in my opinion, so it should be in the HTML with a proper
alt
text instead of in CSS
CSS
- no particular comment here, though you may want to look into CSS custom properties (or variables as they are often called as well) to have a centralized place to edit those instead of having to edit them all over your code
0