@ghintema
Posted
Hi Dodeun,
I've just reviewed your code and I've seen that you applied fix paddings on the sections. I'd suggest to change that to a % value to have more space for the content in case of smaller screens. You would improve responsiveness this way...
And from semantic point of view: I think its better to make the "build the comunity..." - call to action part of the main. You've put it in the header. For a reason?
Hope to have helped you. Always happy coding! :)
Marked as helpful
@Dodeun
Posted
@ghintema I do tend to use fixed paddings in challenges to match the design but I shoud like you said change that to a % value and a max-width to avoid ugly behavior for larger screens.
I need to look into best practices for the "build the community" part. I considered it like a hero doubling down as a call to action, seeing there was a second smaller one a bit later on the page inside the "main" part I decided to separate them and put the first one in the header but it may have been a mistake !
Thank you for your feedback.
