@ezeaniiandrew
Posted
Great design, You were able to reproduce the design and that is an important step. The next step is to make your code better and here are some suggestions to guide you:
-
I noticed that all your images on each section were enclosed in a parent container. I don’t think it’s necessary as the other contents of the sections are already enclosed in a parent container, so setting a display flex on the common parent container will still give you the same results.
-
Your use of labels to separate the different content in your footer section is not good, labels are used with input fields for accessibility reasons. A div tag will best serve for that purpose.
-
The phone number should be in a link tag because we would like a potential customer to be able to call the company when they click on that number.
-
Using descriptive names when naming classes and ids is a core part of the job because it not only helps maintaining the code easier but it also helps you when you want to review your work sometime in the future and apply the new things you have learnt to make it better. If you’re are not using a css framework (I’m not familiar with frameworks naming conventions because I only write vanilla CSS), I will advice you read about BEM naming technique and apply them in your future projects.
Marked as helpful
