Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

huddle landing page with alternating feature blocks - html, scss

Kim Song 205

@CaptKraken


Design comparison


SolutionDesign

Solution retrospective


i feel like things are a little too big, so i tried giving the images small sizes. i regret not dividing the code up into components files lol

maybe i'll do it next time.

Community feedback

P
Grace 27,950

@grace-snow

Posted

Hi

Looking at the html most looks great, just a few small pointers

  • you don't need to add aria labels to links that have written content in them
  • icons like those used for address and phone in the footer can be skipped (empty alt)
  • footer links to areas of the site should be in a navigation element. This would need an aria-label="footer to differentiate it from any other navigation that may appear on pages.
  • instead of two uls for links in the footer you could use one and column properties in css (optional idea really)
  • really important to remove all those tabindexes. Look up what tabindex is for and how it should be used

Good luck ☺

1

Kim Song 205

@CaptKraken

Posted

@grace-snow thanks for the suggestions! i've fixed the mistakes you pointed out, i think.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord