Hi
Looking at the html most looks great, just a few small pointers
- you don't need to add aria labels to links that have written content in them
- icons like those used for address and phone in the footer can be skipped (empty alt)
- footer links to areas of the site should be in a navigation element. This would need an
aria-label="footer
to differentiate it from any other navigation that may appear on pages. - instead of two uls for links in the footer you could use one and column properties in css (optional idea really)
- really important to remove all those tabindexes. Look up what tabindex is for and how it should be used
Good luck ☺
1
Kim Song• 205
@CaptKraken
Posted
@grace-snow thanks for the suggestions! i've fixed the mistakes you pointed out, i think.
0