Hey @Harshitsoni2000 lovely job on this one! š Overall I'd say that you've done a great job. Here's some points you might like to consider:
-
On the top logo, you've set both width and height to be 100%, which is causing distortion. If you just set one and the other as
auto
the CSS won't have to stretch the image and it'll look better - This is a good think for all images. -
You might want to think about stopping the page from spreading too wide a very large screens. There are many ways to do this. I set a grid on the body element, with three columns, as follows:
.center-content {
display: grid;
grid-template-columns: minmax(1rem, 1fr) minmax(375px, 1440px)minmax(1rem, 1fr);
}
.center-content > * {
grid-column: 2;
}
This puts all the direct children of the body, mostly, my header, main, and footer the middle column, and stops them going wider than 1440px.
This issue will come up in so many challenges so it's worth spending a while to get comfortable with an approach that works for you.
Great work and cheers for now š
Marked as helpful
@Harshitsoni2000
Posted
@dwhenson Thank you sooo much for this detailed review. I will surely remember this.