Skip to content
Submitted about 3 years ago

I developed one of the Frontend Mentor challenges using HTML and CSS.

bem
Alejandra Olazagasti•100
@AlejandraOlazagasti
A solution to the Order summary component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

All feedback is welcome. Thank you!! 🙂

Code

Please log in to post a comment

Log in

Community feedback

  • Vanza Setia•27,715
    @vanzasetia

    Hello, Alejandra Olazagasti! 👋

    Great work on this challenge! Your solution looks pretty good! 😀

    I see some areas in your code that you can improve.

    • I would not recommend wrapping the anchor tag with a form tag. I recommend using form element when there's data that needs to be submitted. The link element is used to navigate the users to another page or website (no submitting).
    • figure element doesn't need to wrap every img element. The only reason to use figure is if you need to include a figcaption. Otherwise img tag is fine.
    • The illustration and the icon music are decorative images. So, I would recommend leaving the alt="" empty to hide those images from screenreader users. By doing this, it will make sure that the screenreader users focus on the main content of the site.

    Hope this helps. 🙂

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord