Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

I made this component using flexbox and custom properties CSS

@Starlk

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I think I have a problem with the order of properties CSS, it isnΒ΄t some bad but I would know what is the correct order for the properties CSS or the way most optimize

Community feedback

JfuseCodesβ€’ 270

@JfuseCodes

Posted

As far as the background what i did was this: background-repeat: no-repeat;

This should stop the background from looping over and over.

Marked as helpful

0

@Starlk

Posted

@JfuseCodes Thanks so much. I didn't see that 'cause I just worked Mobil version, thanks for your feedback πŸ™ŒπŸ˜Š

1
P
Kenβ€’ 4,915

@kens-visuals

Posted

Hey @Starlk πŸ‘‹πŸ»

I have some suggestions to help you fix the accessibility and HTML issues.

  • In your markup, <section class="card">...</section> should be <main class="card">...</main> and <div class="attribution">...</div> should be <footer class="attribution">...</footer>. These will fix the accessibility issues. Don't forget to generate a new repot once you fix the issues.
  • For the music icon, add aria-hidden="true”, because it's for decoration. You can read more about aria-hidden here. Like so:
<img src="/images/icon-music.svg" alt="" class="plan__icon" aria-hidden="true”>
  • Hero image should have a display: block;, it removes the line underneath the image. If you want to know what's causing it, check out the 3rd section of this video.
  • Next, if you're not using srcset, you should remove it otherwise it's causing some errors.
  • Also, I suggest implementing :hover state, which you can find in design folder active-state image, after you implement it you can also add transition: all 0.2s; to the button and the links, this will make :hover smoother.
  • Lastly, let's fix the background image and here's how to do it:
body {
    background-image: url("/images/pattern-background-desktop.svg");
    background-repeat: no-repeat;
    background-size: contain;
    background-color: #e0e8ff;
    min-height: 100vh;
}

I hope this was helpful πŸ‘¨πŸ»β€πŸ’» all in all, you did a nice job, keep it going. Cheers πŸ‘Ύ

Marked as helpful

0

@Starlk

Posted

@kens-visuals thanks so much for your feedback 😊 , I already added change to the repo. I didn't know accessibility HTML, thanks πŸ™Œ

0
P
Kenβ€’ 4,915

@kens-visuals

Posted

@Starlk you're welcome πŸ˜‡

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord