Submitted almost 3 years ago

I made this tip calculator with mobile version first in mind.

Tenzin Dekyong Dhondha• 40

@tenzind12

Preview site View code

This is a solution for...

Tip calculator app

HTML
CSS
JS

2junior

View challenge

Design comparison

SolutionDesign

Solution retrospective

I am super new to javascript, in fact to the programming world. Please feel free to correct my code and advising me on how things can be done differently. You can also share tips on how to keep growing as a programmer. Thank you all.

Community feedback

Dinesh• 1,115

@Dinesh1042

Posted almost 3 years ago

Hello, tenzind12 👋

Great work on this challenge, Here are my few suggestions on your solutions.

Tip Calculator works only when the user clicks on the select tip. If the user changes the bill amount or number of people. It's not updating.
There is no indication which tip is currently selected use classes or radio inputs to manipulate dom
Your .p1 and .p2 font-size are too small and slim

Well, that's it. Happy Coding!

Marked as helpful

Tenzin Dekyong Dhondha• 40

@tenzind12

Posted almost 3 years ago

Hi Dinesh, Thank you for ur feedback. I added the eventListener on the tip buttons and custom. Bad idea. I will keep that in mind. I dont understand the second point. If u have time, can you explain me a little?

Thanks man.

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord