Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

I used CSS grid and JavaScript to make it responsive

Edoye•170
@DoyeDesigns
A solution to the E-commerce product page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


This project opened my eyes to a lot of concepts. you can achieve 1 thing in different ways in javascript, but I'm really interested in the dynamic way of doing it, where it can scale independently. PLEASE can you recommend core basic concepts that I will have to master to be able to understand javascript at a fundamental level?

I'm unsure of the delete item from cart functionality. please can you suggest a better way to do it?

What is your process for solving functionality problems in your projects? and do you have a general approach to all the problems? Do you start simple and then work it all the way up to its complex form?

I'd really appreciate feedback on my code and expert advice. Thank you

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Abdul Khaliq 🚀•72,380
    @0xabdulkhaliq
    Posted over 2 years ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    BUTTONS 🖲️:

    • This solution had generated accessibility error reports due to lack discernible text for <button> element

    • The <button> must have discernible text that clearly describes the destination, purpose, function, or action for screen reader users.

    • Screen reader users are not able to discern the purpose of elements with role="link", role="button", or role="menuitem" that do not have an accessible name.

    • The <button> name rule has five markup patterns that pass test criteria:
    
    <button id="al" aria-label="Name"></button>
    
    <button id="alb" aria-labelledby="labeldiv"></button>
    
    <div id="labeldiv">Button label</div>
    
    <button id="combo" aria-label="Aria Name">Name</button>
    
    <button id="buttonTitle" title="Title"></button>
    
    
    • Ensure that each <button> element and elements with role="button" have one of the following characteristics:

      • Inner text that is discernible to screen reader users.
      • Non-empty aria-label attribute.
      • aria-labelledby pointing to element with text which is discernible to screen reader users.
      • role="presentation" or role="none" (ARIA 1.1) and is not in tab order (tabindex="-1")

    . .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful
  • P
    visualdennis•8,375
    @visualdenniss
    Posted over 2 years ago

    Hello there,

    very nice work! It seems like you have spent quite a bit time and effort on this project but you have successfully completed it in the end!

    One note i'd like to make is that avoid using alert("Product already in cart!"); in production, it is only okay to use when debugging in development, but alert() will block your JS code execution and also might open some security vulnerabilities and also not a great user experience, better option is to use modals.

    "Do you start simple and then work it all the way up to its complex form?"

    In general i try to breakdown the problem into managable small tasks as much as it is possible. Before starting a project, i try to do that but also try to keep a picture as a whole about how all these small functionalities would eventually connect and come together.

    It looks like you are passing a huge amount of HTML through Javascript. Most of it, needs not to be dynamically created but could be part of static HTML file, only the changing parts could be updated. But if you wanna dynamically create HTML, i can recommend to stepping up to a JS Library like React JS later on, where you write HTML-like elements inside Javascript.

    But to deepen your fundamentals, i'd recommend going through a book, e.g. Eloquent Javascript is pretty good one: https://eloquentjavascript.net/

    Hope you find this feedback helpful!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub