Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 1 year ago

I used Custom CSS in this project. I used Flex box instead of CSS Grid

Syed Muhammad Zain Ul Abideen•20
@imszain5
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I am proud of that by completing these projects it will enhance my skills and will help to gain valuable knowledge and hands on experience. I want to write more complex code next time .

What challenges did you encounter, and how did you overcome them?

Little bit challanges I faced and I overcome it with the help of google. And That's it.

What specific areas of your project would you like help with?

It help me with the html and Css. And I gain valuable knowledge.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Shane Coco•20
    @SSGBC
    Posted about 1 year ago

    Viewing the source code for the solution there are mostly div tags used in the HTML which could be updated to tags that have more semantic meaning. There are multiple classes create and there one of which is not used in the CSS style sheet. The HTML and CSS code are well structured and are readable. The solution does differ slightly from the design which can be corrected with a few tweaks to the CSS code.

  • Oseremen Godstime•80
    @devandytech
    Posted about 1 year ago

    Trying improving on your color palette, I suggest you use the one provide on the read.md file

  • P
    Øystein Håberg•13,260
    @Islandstone89
    Posted about 1 year ago

    HTML:

    • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Change the first <div> to a <main>.

    • You don't need all of those divs! You only need one <div>, which holds the card content - I would give it a class of .card.

    • The alt text must also say where it leads(frontendmentor website).

    • "Improve your" should be a <h2>.

    CSS:

    • Including a CSS Reset at the top is good practice.

    • Use the style guide to find the correct font-family.

    • Use the style guide to find the correct background-color.

    • Add around 1rem of padding on the body, so the card doesn't touch the edges on small screens.

    • To center the card horizontally and vertically, use Flexbox on the body:

    display: flex;
    flex-direction: column;
    justify-content: center;
    align-items: center;
    min-height: 100svh;
    
    • Remove all widths and heights.

    • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

    • Add text-align: center on the card to center the text.

    • To create the space between the image and the edge of the card, set padding on all 4 sides of the card: padding: 16px.

    • On the image, add display: block and max-width: 100% - the max-width prevents it from overflowing its container. Remove the margin.

    • Add border-radius: 10px on the card and the image.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub