i used only sass as framework and the usually css, html and js

Solution retrospective
hi,
that's my first challenge and i'm pretty new in the web developement, i would like to have the feedback on the class name and the way i structure my html. To Have some advice on the good practices to adopt. Any relevant advice is welcome. thanks
Please log in to post a comment
Log in with GitHubCommunity feedback
- @qb-rivkyb
Hey! Nice job! A few things I noticed which I would change is -When working on responsive sites it is best to start mobile first and only do the layout styling in a media query for desktop/tablet. -Also I noticed the background image does not look so nice and it doesn't keep its ratio. The way to get around it is to add background-size: cover to your css.
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord