Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

i used only sass as framework and the usually css, html and js

@elsong1210

Desktop design screenshot for the Insure landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


hi,

that's my first challenge and i'm pretty new in the web developement, i would like to have the feedback on the class name and the way i structure my html. To Have some advice on the good practices to adopt. Any relevant advice is welcome. thanks

Community feedback

Coder 270

@qb-rivkyb

Posted

Hey! Nice job! A few things I noticed which I would change is -When working on responsive sites it is best to start mobile first and only do the layout styling in a media query for desktop/tablet. -Also I noticed the background image does not look so nice and it doesn't keep its ratio. The way to get around it is to add background-size: cover to your css.

4

@elsong1210

Posted

hi @qb-rivkyb,

thank you very much for your feedback. I will take your comments into account. i would like to know if the way i name my class is correct. if not, can you advice me one ressource where i can learn the good practice about it. Thank you

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord