Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 4 years ago

Insure Landing page

Mehdi•70
@mehdilehmamy
A solution to the Insure landing page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


how much can my css code be better, I know it's inefficient but I don't know to what degree. 500 lines of css for a simple landing page is a bit too much I think.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Steven Toben•750
    @steventoben
    Posted over 4 years ago

    There's a lot of incorrect html semantics going on. Your nav should hold anchor elements since a nav is supposed to be your main source of navigating throughout your page. On your hero section I'd change your flex's justify content to space between or something similar. You could also make the paragraph under the main h1 more legible by setting a max-width to something like 60ch. That would probably help it from overlapping with the image. Also you should only use one h1 element on your entire page. You're using far too many. h1 is the most important heading and then you should work down to h6, which is the least important heading. I also think you're abusing flexbox quite a bit. You could definitely use different display types throughout and it would work just the same. Anything that looks like a button, should be a button or anchor element. Also on the very bottom in your footer, you should use an unordered list for all of those lists. And all the list items inside the list should be anchor element because they represent links. Overall tho I mean it looks nice, it think the stylesheet is long because of the way you implemented your media queries.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub