@pikapikamart
Posted
Hey, awesome work on this one. The desktop layout looks really great and those animations is really nice and suits well on the design. The site is responsive and the mobile state looks great as well.
Here are some suggestions for the site:
- For the
.intro
selector, I would change the usage ofmin-height: 65vh
into usingrem
unit so that it will be consistent. At my monitor, the hero-section's bottom part is touching theview plans
because my screen is not that tall since I am just using 1366x768. - The
source
from thepicture
doesn't really need to use thearia-hidden
attribute. - For me, the hero-image could be a meaningful element since if you read the hero-text, it is all about the image, meaning it paves way to the image.
FOOTER
- Each of the
a
tag for the social media should be using the social media name as thearia-label
text, currently alla
tag usessocial media
as the value which is ambiguous for user to where this link would take them. - Add an extra
aria-hidden="true"
on thesvg
for each of the social media icon. aria-label="footer"
is much used rather thansecondary
. You want thenav
to be more clearer for what it will serve to the user. Because there arebreadcrumbs
usage ofnav
as well.
MOBILE
- It's just an idea if you want. You could create a trap focus on the navbar when toggled. This way, if I toggle the hamburger, even if I use
tab
again when I am at the last link-item, I would end up on the hamburger again and vice-versa when usingshift + tab
on the hamburger, I would end up on the last link-item, hence focus trapping. This way, user won't go out of place when such pop ups appear.
This is a really nice solution to be honest. Usage are really great^^
Marked as helpful