@ApplePieGiraffe
Posted
Hey, Clem FRontend! π
Your solution looks great! π Good job with the semantics, accessibility, and functionality of the form, as well! π
I wouldn't make the credit card number the h1
of the page since it isn't a very meaningful heading and doesn't describe the content of the page to users. Instead, given that the design of this page doesn't have a visible heading, you can add an invisible heading for semantics (as every page should have at an h1
) and screen readers. Check out this helpful read on the topic.
And one minor thing in terms of designβit would be good to add a max width to the form in the tablet view so that its controls don't become too wide when the layout first changes from desktop to tablet.
Also, as @eng-milan mentioned, splitting your CSS into separate files is a good practice moving forward since it makes things easier to organize and work with (especially in large projects). π
Hope you find this helpful. π
Keep coding (and happy coding, too)! π
Marked as helpful
@vivitare
Posted
Hello @ApplePieGiraffe , First thank you for your feedback π
Interesting things about h1 and max-width, I take a note for the future !