Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Interactive comment section

#accessibility#react#fetch
Icekid35 260

@Icekid35

Desktop design screenshot for the Interactive comments section coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
3intermediate
View challenge

Design comparison


SolutionDesign

Solution retrospective


I would love your feedback

Community feedback

@SeyBoo

Posted

Hello ! Bravo for your first react solution ! For best practice you could :

  • Create a file for every component that you created so it's easier to read
  • The App file is not a component so i shouldn't be in the components folder
  • Instead of using style={{display:show ? "":"none"}} you should look for conditional rendering (I was doing the same mistake ahah)

https://reactjs.org/docs/conditional-rendering.html

const [showModal, setShowModal] = useState(false);

{showModal ? <Modal />  : null }
<button onClick={() => setShowModal(!showModal)}>Display modal</button>

Have a nice day :)

Marked as helpful

0

Icekid35 260

@Icekid35

Posted

@SeyBoo thanks for the tips I'll surely improve on them

1
Travolgi 🍕 31,500

@denielden

Posted

Hi Icekid, great work on this challenge! 😉

Here are a few tips for improve your code:

  • add descriptive text in the alt attribute of the images of users and not user for all
  • use p for the text and not span element
  • add transition on the element with hover effect
  • instead of using px or % use relative units of measurement like rem -> read here
  • if I click on the upvote button I can increase it to infinity and not just by 1 point. add a control
  • i can comment also with empty comment or with blanks, add a control... The trim() method can help you -> read here

Overall you did well 😁 Hope this help!

0

Icekid35 260

@Icekid35

Posted

@denielden thanks alot for all the tips, I surely make use of them

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord