@elaineleung
Posted
Hi Bazthos, well done building this out with React! This looks great, and everything works fine for me. I suggest adding cursor: pointer for all the clickable elements since that's also in the design and also that just makes for better user experience when it's clear to them that the element is interactive. Also, for the upvoting and downvoting comments, I think that should only go up or down by one step because right now, I can keep voting up and/or down and can give someone 10 votes if I wanted to. If you look at Reddit for instance, after clicking on the up/down vote, when you click on it again, it would get unclicked instead of adding another vote. So anyway, I would most probably add in some logic to make sure only one vote is counted.
Great job, and looking forward to more!
Marked as helpful
@Bazthos
Posted
@elaineleung Hi Elaine !
Thanks for reviewing my solution.
Concerning the design, I had forgotten to focus on it, I worked on the hover / animation / cursor . Hopefully this new version is more acceptable :)
For the votes, I revised the system to allow only one vote. I had focused too much on the possibility to sort the comments according to the votes.
Thanks again for your comment, it allowed me to review my solution and to realize that I was trying a little too hard to rush the interactivity before finished the design.
Happy coding :)
@elaineleung
Posted
@Bazthos Glad to help! It's happened to me too where I left things out accidentally. That's what I love about the FEM community; there's usually a couple other pairs of eyes out there helping to check!
