@visualdenniss
Posted
Hey Jo,
great work! This one is a quite tricky challenge and u have did an amazing job :)
There seems to be little issue with the vote system. Once u vote, if u can only cancel that vote but u cannot vote the opposite way. E.g. if u upvote, it goes up to 5, but if u downvote it never goes to 3, which should be the case. I've listed here Vote System States. Also i dont think it is necessary to put an explicit warning to a user. The standard practice on web is to toggle when clicked twice, instead of a pop up alert.
Its also very nice that u added little menu to switch users. I've also initially wanted to make a menu like u and display users with animation onClick, then i thought since this is a demo, people might not spend time much, so i wanted to make it very explicit. But if it was a real-world thing, i'd hide them into a menu too.
Hope you find this feedback helpful! Keep up the great work ;)
Marked as helpful
@Jo-cloud85
Posted
Hi @visualdenniss, thanks for the encouragement! It was definitely tedious for me to complete the challenge using plain Javascript.
Yeap, you noticed the bug at the vote buttons.π I have just fixed it! Instead of a pop-up alert, when the user has either upvoted or downvoted, the icon should stay blue as a way to notify the user that he/she has voted. The user should be able to vote the opposite way now as well.
On the other hand, I am still keeping the pop-up alert if the user is attempting to send an empty response.
@visualdenniss
Posted
@Jo-cloud85 Looks amazing!