Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 4 years ago

Interactive pricing component | Pug, Scss & Vanilla JS

MasterKrab•940
@MasterKrab
A solution to the Interactive pricing component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I am just a beginner and would appreciate any feedback.

Do I have good practices? What errors do I have? How could I improve my code?

Thanks <3

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Dave•5,295
    @dwhenson
    Posted over 4 years ago

    Hey @ MasterKrab 👋 - this looks great!! 🙌 You've matched the design really well and the site is nice and responsive.

    Some, very small, suggestions for you:

    1. There is some inconsistency in your focus states (you've styled the range input and checkbox really nicely, but the button gets the default styles). I have recently started adding the following to my code as a basis for catching this:

    `:focus-visible { outline: 3px dotted currentColor; outline-offset: 0.25rem; }

    :focus:not(:focus-visible) { outline: transparent; }`

    This helps me catch this error. Of course you might have to change the color etc but I find it generally works. And don't forget to set your pointer to cursor! This will help let your users know where they can click.

    1. I had to google whether it's OK to have two labels for one element, and it's not clear that it is. I think this page suggests it would fail a lighthouse test: https://web.dev/form-field-multiple-labels/ but this page has a much better assessment (scroll down for the summary table): https://scottaohara.github.io/tests/html-inputs/double-label.html Seems like Safari is the main issue in this case.

    Your JS seems really solid and I'll be having another look at your code there as I think it is much more concise than mine when I tried this challenge!

    Great work on this one! Really nice job and I've learnt somethings reviewing the code, which is always great! 🎆

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub