@buneeIsSlo
Posted
Hey! @Odiesta, Good job on this challenge, your webpage responds very well!
Here are my suggestions:
-
You don't need to have a default rating i.e
rateValue = 5
. Use thedisable="true"
attribute to keep the submit button disabled until the user has provided a rating. Fiddle with this codepen by Elaine to learn more about this method. -
As far as accessibility is concerned, your rating options aren't keyboard-focusable. This is because your rating options are list items as opposed to buttons. To fix this, wrap the list items in
<button>
tags and style them accordingly.
Hope this helps :)
Marked as helpful