Submitted 11 months ago

Interactive Rating Card Component using Vanilla JS

#accessibility

Destiny Adebayo• 40

@ProfessorDy

Preview site View code

This is a solution for...

Interactive rating component

HTML
CSS
JS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

Please check for any way I could Improve my code.
Best practices for JS is also welcome.
Any form of criticism is welcome.

Community feedback

Abdul Khalid• 69,100

@0xabdulkhalid

Posted 11 months ago

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

I have other recommendations regarding your code that I believe will be of great interest to you.

BODY MEASUREMENTS 📐:

Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation

For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Destiny Adebayo• 40

@ProfessorDy

Posted 11 months ago

I now understand viewport units even more from your explanation. Thank you so much. I will make the adjustment @0xAbdulKhalid

Abdul Khalid• 69,100

@0xabdulkhalid

Posted 11 months ago

@Dy-Prof Glad you found it helpful ! 🤠

_nehal💎• 6,730

@NehalSahu8055

Posted 11 months ago

Hello Coder 👋.

Congratulations on successfully completing the challenge! 🎉

Few suggestions regarding design.

➨ Use Semantics for the proper design of your code.

<body>
<header>
<nav>...</nav>
</header>
<main>...</main>
<footer>...</footer>
wrap up `.attribution` inside `footer`
</body>

➨ For image like .svg are decorative which screen reader will not render it to be important and skip it, so it make no sense to add alt leave it blank.

➨ You can use accessibility features like aria, sr-only, and title which are accessible to screen readers.

I hope you find this helpful.

Happy coding😄

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord