Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Interactive Rating Component

#accessibility#semantic-ui
P

@mah07308

Desktop design screenshot for the Interactive rating component coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@thomashertog

Posted

Solution is looking good (visually). There are some things to improve your code though.

HTML

  • you have a <button type="submit"> but there is no <form>
  • the star image is decorative (at least in my opinion) so it should have aria-hidden attribute
  • the ratings should be an <input type="radio"> in order for the form to submit meaningful data. you can find more info here
  • you might want to work with a hidden attribute for the thank you container in order to remove it from your accessibility tree as well until the form is submitted

CSS looks clean, couldn't find improvements there however, you may want to remove those commented lines as they distract you from the code that is needed

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord