@darryncodes
Posted
Hi Mohsin,
Really nice work on this challenge, well done.
And great perseverance to complete the solution with radio buttons too!
Some considerations for you:
- check out a <fieldset> for your
.rating-container
. It is a semantic element to choose compared to adiv
and has some interesting attributes you might use in the future - you should consider adding
cursor: pointer;
to your interactive elements to give that additional feedback to the user on desktop - also it'd be great to see some focus states added to those interactive elements for those who navigate the component using a keyboard
- your accessibility report is suggesting you need to use a landmark element like a
<main>
, here is some more information for you - lastly you could consider making the card and thank you result the same dimensions, so when it changes you don't notice a difference between the layouts as much
Overall you smashed it, with a few tweaks you could level it up even further!
All the best!
@mobasher10
Posted
@darryncodes thanks bro for your feedback I will try these suggestions in my next challenges