Hi Nguyen,
Thank you for your valuable feedback, I'll make the necessary edits. Hoping to get more feedback from you on my future submissions.
Looking to hire developers?
@jesuisbienbien
Posted
Hi Jester,
Good job on completing this challenge. There are a few issues that I'd like to suggest:
1- I'd suggest you create a media query for mobile view. There should be padding in the container so everything doesn't lie too close to the edge. Also, maybe smaller font-size for heading and paragraph.
2- Using inline styling is okay, though I created a class .hidden and add that class to the part that you want to hide and remove it otw.
.hidden {
display: none;
}
3- The paragraph should have a line-height so it spaces out a little.
4- I suggest that you add a transition on the button on hover so it looks smoother.
I had also finished this challenge. You can check out my solution here
Hope this helps.
Happy coding :D
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord