CyrusKabir• 1,885
@CyrusKabir
Posted
Hello my dear friend ♥ you did good on this challenge and here some improvements :
- for having circle shape on rating buttons your buttons should have equal width and height and also an 50% border-radius
- try to change spacing values like padding or margin for getting close to main design as possible
- you used
disabled
attribute to force user select a rating number but there is few problems :
- first, user can't submit buttons with keyboard (tab key), because it's disabled (accessibility issue)
- second, if user know how to inspect he/she can easily remove that disabled attribute on submit button and see thank you card without rating ! so good practice here is change validation check for that rating buttons and remember to print an error message when user did not click on a rating button and tried to hit the submit button
0