Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 3 years ago

Interactive rating component

sass/scss
Jonas Stempickij•50
@JonasStempickij
A solution to the Interactive rating component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Should I leave or delete scss files?

Structure of my scss and HTML file.

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Fluffy Kas•7,655
    @FluffyKas
    Posted about 3 years ago

    Heyo,

    It looks good! In addition to what @Sdann26 already said, you could look into the following:

    1. Instead of using buttons, radio inputs are a better choice for the ratings.

    2. You shouldn't set a fixed height on your card - or in general on most elements. If you remove it, you'll see little has changed. This is because html elements have their own default height. You can add some padding to this, if it isn't enough.

    3. You could add a rule to prevent empty submits.

    And yes, you should always upload your scss files to Github. If someone tried to look into your code, the scss you worked on is usually easier to follow than the complied css. ^^

    Marked as helpful
  • Danilo Blas•6,300
    @Sdann26
    Posted about 3 years ago

    Hi Jona! Congratulations on finishing your first project!

    You should never delete them, since you program in a development environment so you modify those files in development. The files that are generated are passed to a production environment that has better performance for your page, more or less this is how it is handled. You will see that later on when you get more experience.

    Leaving aside the question, in your design the star does not appear and it is because you have not used relative paths. So modify <img alt="" src="/images/icon-star.svg"> to <img alt="" src="./images/icon-star.svg">, you will notice that it has a dot before the slash as that is a relative path because it starts from where the file that calls the path is located.

    If you want to make the spacing in the SUBMIT button you can add the attribute letter-spacing: 0.25em, also you can add to this button and to the score buttons the attribute to give a transition to the change of state and that the effects are given more smoothly transition: all 200ms.

    I hope my comments are helpful.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub