@Zukizuk
Posted
Hello there, Congratulations on completing this project
Your solution looks nice
I have few suggestions that I think might be of interest to you.
- HTML:
Consider using semantic HTML tags like <main></main>,<section></section> and others that you can find in this link. And in this case, replace the <section class="card"> with <main class="card">. the main tag should hold the main content of the page so consider correcting that.
The semantic HTML tags help the search engines and other user devices to determine the importance and context of web pages. The pages made with semantic elements are much easier to read. It has greater accessibility.
Also I think your use of sections here is a little bit much, though we say don't use div when you don't have to because they don't have any semantic value, but in this case using div seem perfectly fine to me because this single card does have a maximum of two section which will be the rating and the thank you sections but I saw that you used section to separate the buttons and text on the card which I think you should have used div here. They are all on the same section. Use section when the content are not related. You can read more about it from the link I provided.
I hope this feedback is helpful
Other than that great job
Marked as helpful
@johnnysedh3lllo
Posted
thanks so much @Zukizuk for you suggestions, i must admit i had been shying away from using divs, to avoid misusing them and i very much agree with you that i could have used them to divide up the content in this case. I'm currently still learning how to write Semantic HTML but i guess my understanding isn't well cemented yet, the resource will help alot. Thank you so much, really appreciate the feedback.
@Zukizuk
Posted
@johnnysedh3lllo You are welcome, using section also require you to provide a heading for that section so be mindful when using it
@johnnysedh3lllo
Posted
@Zukizuk i think i'm beginning to see the patterns, thanks man.
