Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Interactive Rating Component (my 3rd JS project)

Nguyen Nguyenā€¢ 340

@jesuisbienbien

Desktop design screenshot for the Interactive rating component coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello, this is my 3rd JS project. I'm starting to get a feel of how JS works but I'm still a beginner, so I hope to receive many feedbacks so I can learn. Thank you in advance.

Community feedback

Shashree Samuelā€¢ 9,260

@shashreesamuel

Posted

Hey good job completing this challenge

Keep up the good work

Your solution looks great however I think that that the card title needs a bit of margin from the top using margin-top.

In terms of your accessibility issues simply wrap all your content between main tags

I hope this helps

Cheers

Happy coding šŸ‘

Marked as helpful

0

Nguyen Nguyenā€¢ 340

@jesuisbienbien

Posted

@TheCoderGuru The margin-top is definitely needed. How could I miss that? :D Thank you! Happy coding.

0
Prabhash Ranjanā€¢ 2,540

@besttlookk

Posted

Hi, Nicely done. Only thing i can point out is :

  • On Active state of button. chage the color of to white. As of now it is not quite visible

Also You can't reuse the ID. Id should always ne unique.

<button id=`number` class=`number` type=`submit` value=`3`>3</buttton>
<button id=`number` class=`number` type=`submit` value=`4`>4</but

Remove the id.or give uninque id to each .

Good luck, Happy Coding

0

Nguyen Nguyenā€¢ 340

@jesuisbienbien

Posted

@besttlookk thank you. I'll update my code asap. :D

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord