@YariMorcus
Posted
Hi Aaron,
First of all, I think you did a great job coming up with a solution for this challenge. It looks exactly like the design, it is functional and also responsive.
There is one thing I noticed and that is the following.
I can press the submit button without selecting a number. This results in the message You selected out of 5
(missing the number). You could give it a default rating number (which you should not do in a real application unless clearly indicating what this number will be), or you could also disable the button and enable it when the user selected a rating.
It appears you get to choose haha.
I hope you can do something with this feedback. If you still have questions, let me know.
If I made a mistake somewhere in this post, feel free to correct me and keep building awesome things :D.
Marked as helpful
@digitalherding
Posted
@YariMorcus
Thank you for this feedback! Yes! I did not realize this. You made me realize I definitely did not do enough testing! ;) I really appreciate your time and feedback.
@digitalherding
Posted
@YariMorcus
I adjusted my JS for when the user makes no selection! I just added a simple alert() message catch for now. Maybe later I will go in and add it on page, but for now I left it as an alert.
Thanks again for your feedback. It really helped!