Design Comparison
Reports
All page content should be contained by landmarks
<div class="attribution">
Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>.
Coded by <a href="#">Mohamed Lajnef</a>.
</div>Mohamed Lajnef’s questions for the community
There is a bug when you hover after selecting and deselecting the rating. I am unsure about the way I wrote the css file. I believe there is a lot to improve. Any feedback is welcome.
Community Feedback
@AdrianoEscarabote
Posted
Hi Mohamed Lajnef, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:
Document should have one main landmark, this problem is being caused by the fact that there is no main tag around the main content of the page! Since this challenge is based on only one component, there is no other component more important than it on this page, so to solve this, wrap all the content with the main tag,
It's always good to pay attention to the correct use of semantic html elements, as they are extremely important for people who use screen readers, to know what the main content of the page is in the case of the main tag!
To improve the accessibility of the project you could have put an h1. Every page must contain a level 1 header, for people who use screen readers, identity what the main title is and follow the sequence h1-h5
<h1>How did we do?</h1>
The rest is great!
I hope it helps... 👍
Marked as helpful
1
@momolajnef1
Posted
@AdrianoEscarabote Buddy! I am doing fine. I hope you do too. I love your projects. I looked at them and felt inspired to keep going. Thank you for the feedback. Indeed I appreciate it a lot. New Information that I didn't know about. I will be more careful with the next projects.
1
