Interactive rating component - React / Typescript / SASS
Solution retrospective
This was my first time using Typescript and SASS. Still learning. I also sent props down two levels (prop drilling) instead of using context but I didn't think the overhead was worth it for such a small project.
I'm also not sure that I handled media query breakpoints correctly with SASS. Seems like a bit of a hassle to locate the queries across multiple files if I need to change things. Maybe there's a better way.
Please log in to post a comment
Log in with GitHubCommunity feedback
- @nikavolk
Hello Marc!
I've completed this project with React as well, so here's my input:
Visually: looks great! I can't find any faults at all, really.
Technically:
- one minor bug in the ThankYouInner component on line 16 (rating {variable} out of 5).
- choosing a rating and clicking submit works on every rating except for the first, might be just my device?
- just my very personal opinion: there seems to be a lot of code for a rather simple component
I loved your folder and file structure and will definitely work on making mine in a similar fashion (lots of small component files for each part of the app). As for SASS styles and files, I think they need to be imported into every child but honestly, I need to look into this myself.
Great job!
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord