@VCarames
Posted
Hey there! π Here is some feedback to further improve your code:
- The HTML for the ratings needs to be rewritten as it was done incorrectly β:
To ensure that the "rating buttons" are fully accessible π―, they need to be built using a form
β οΈ.
- Everything will be wrapped inside a
fieldset
which will have alegend
that is visually hidden using CSS. - Inside, there should be five
input radios
and eachinput
should have alabel
attached to it to make the βratingsβ accessible. - The last thing you will want to include will be a
button
so users can submit their choice.
More Info: π
- Once the top is implemented , for your JS, the
eventListener
should be on theform
β οΈ as asubmit
.
More Info:π
Click vs. Submit EventListeners
- Currently, you "thank you" content is not being announced β οΈ to screen readers. So you need to wrap it it in another
div
and give it aaria-live="polite"
(it should only have this and nothing more).
- The
h4
in your "thank you" content should be ap
instead, since it is not a heading.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! πΎ
Marked as helpful
@kylekasprzyk
Posted
@vcarames thank you for all of the help!