Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Interactive rating component

yudiz 180

@yud11z

Desktop design screenshot for the Interactive rating component coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


All feedbacks are welcome, thanks in advance

Community feedback

P
ApplePieGiraffe 30,545

@ApplePieGiraffe

Posted

Hi, yudiz! 👋

Great work on this challenge! 👍

I noticed the card component is centered in the screen on all screen sizes. Rather than add height: 100vw to the main element, I suggest adding min-height: 100vh. That'll ensure that the main element is always at least as high as the viewport and the card component will be in the center of the screen at all times. 😉

Besides that, I think you can improve the semantics of your HTML just a bit by using a p tag for the description of the card component and button tag (rather than an a tag) for the submit button. Using button tags for the options themselves would also be a good idea!

Hope you find this helpful. 😊

Keep coding (and happy coding, too)! 😁

Marked as helpful

1

yudiz 180

@yud11z

Posted

@ApplePieGiraffe Thanks a lot, that's really helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord