ćć¬ć³ćæć¤ć³ šā¢ 64,250
@VCarames
Posted
Hey there! š Here are some suggestions to help improve your code:
This is not the ideal first challenge users should tackle; even though it seems simple, it actually quite complex.
- As the challenge name suggest, this is an interactive component. Meaning that it needs to be accessible to screen readers and keyboards, which currently yours is not...
- You chose to use
div
for your rating buttons, unfortunately. this is the incorrect element to use sincediv
elements are not interactive.
- The rating buttons have to be built using an accessible
form
,fieldset
and fiveradio inputs
.
- Once the top is implemented , for your JS, the
eventListener
should be on theform
as asubmit
.
- You are using JS to create effects that should be done by CSS; this is called separations of concern.
- There is no need to have separate CSS files, instead have only have one; as having multiple stylesheets can have negative impact on your sites performance.
- Highly recommend creating a
.gitignore
and adding yournode_modules
and.DS_store
to it as these files are not necessary in GItHub.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! š¾
Marked as helpful
1
alexandrezahraiā¢ 130
@alexandrezahrai
Posted
@vcarames thanks for your detailed feedback - I will take it into consideration.
0