Skip to content
Submitted about 2 years ago

Interactive Rating Component with Flexbox

AlexMagargiu•160
@AlexMagargiu
A solution to the Interactive rating component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

First time writing JS, please do give criticism if I could improve anywhere. I taught about implementing a for in the getValue() function but I don't know how / don't know if it's better optimized than with the single if else condition I used.

Code

Please log in to post a comment

Log in

Community feedback

  • ApplePieGiraffe•30,525
    @ApplePieGiraffe

    Hey, AlexMagargiu! 👋

    Well done on this challenge! 👍 I think you did a good job on the styling and your solution looks good! 👏

    I would suggest leaving the alt text for the icon and maybe even illustration in this challenge empty, since they aren't relevant to the content of the page and we don't really want them to be noticed and read by screen readers.

    And a small tip for your JS—rather than call getValue inside of switchDisplay, you can call switchDisplay inside of getValue if the user has selected an option. This will make your code slightly easier to follow and you won't have to bother with returning a boolean from getValue. 😉

    Keep practicing and with time you'll find better and better solutions to problems you encounter. 👍

    Hope you find this helpful. 😊

    Keep coding (and happy coding, too)! 😁

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord