Interactive Rating Component With React and SASS

Solution retrospective
Any advices on how to improve the styling organization? And is the components' organization for React good enough or could it be more fragmented?
Please log in to post a comment
Log in with GitHubCommunity feedback
- @mseidel819
This looks great! I think your code looks nicely organized, so my comments are just another way of doing it.
I think you could get rid of your container.js and put all of that code into App.js. (and move your container.sass file accordingly, too). That way, you get rid of the middle-man by storing your state inside App.js. It is one less folder, and this extra code inside App.js wont be enough to clutter.
When I did this challenge, I made a
wasRatingSubmitted: false
inside state. Then, I used that to determine which component to show. Thesubmit
button will then have an onClick that will changewasRatingSubmitted
totrue
.{this.state.submitted===true ? <ThankYouState rate={this.state.submittedRating} /> : <ActiveState onRateSubmit={(rate) => this.handleRateSubmit(rate)}/>
This way, you'll have both your
wasRatingSubmitted
andsubmittedRating
inside state incase this project was to expand and now you need to know if the user submitted a rating somewhere else.
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord