Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

Interactive rating component

Edwin_Owino•60
@Edwin574
A solution to the Interactive rating component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I found difficulties in the responsiveness of the component.

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Vendetta Joy•160
    @VendettaJoy
    Posted over 2 years ago

    Hiya, Edwin!

    You've done a good job here, but there is definitely room for improvement!

    Before I get into it, I wanted you to know that I was unable to view your code on GitHub. Maybe check to see you've linked it correctly!

    So just going off of your reports, here are some suggestions:

    • Having a main element is very important! Whatever is within your body tag needs to wrapped with the main tag. i.e.:
    <body>
        <main>
            ...
        </main>
    </body>
    

    and not

    <body>
        <div class="main">
            ...
        </div>
    </body>
    
    • Again, every HTML doc needs to have at most one h1 element. In this case, "How did we do?" will be your h1! You cannot use h2-h6 without having an h1 present in your doc first. I see you have used the h2 heading element, which is wrong! You can later adjust the font-size using CSS.

    • Your img element should not have the srcset attribute if it is going to remain empty. Remove it and it should be fine! You only have it in there if there are alternative images.

    Unfortunately I cannot help you with the responsiveness as I do not have access to your CSS code. Though I see you have used vh (60vh) for the height and a percentage value (40%) for the width. My advice would be to use em instead of a percentage value, and you don't have to specify a height as long as you have specified a width! But make sure you set it as max-width and not width.

    Also for font sizes in projects, I suggest you use rem or em instead of px. For example, this project called for a font-size of 15px, so in rem this would be 0.9375rem. You get this value by doing 15px/16px where 16px (or 1rem) is the default font-size on most devices unless you have changed this in your settings. In that case, it would be 15px divided by whatever is your browser's default font-size! So the rule-of-thumb here is to use rem or em over px to make your website more responsive!

    I hope this helps you! Hope you have a good day, Edwin, and good luck 😊

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub